menu

ZEIT

Our mission is to make cloud computing as easy and accessible as mobile computing. You can find our Next.js community here.

Channels
Team

Github Integration with control for auto-deploy

January 21, 2020 at 5:02am

Github Integration with control for auto-deploy

January 21, 2020 at 5:02am

I love the Github Integration feature. With 1 click everything just works and my app is deployed on every commit. The only problem is that I don't want my app to get deployed until my CI tests have run, which means I can't actually use the Github integration feature and must go with a manual Now CI integration into my CI tool.

This is a little awkward because much of the UI in the Dashboard encourages you to link your project to your repository to enjoy the other benefits (PR builds, etc...). It would be great if I could link my repository to my project, but not have it auto-deploy on every commit automatically so that I can control the behavior via my CI.


January 21, 2020 at 7:33pm

The Github integration does auto-deploy every commit, but it only changes the alias for your domain to a specific commit when you merge to the master branch (or some other branch of your choosing). So you can enable that, put any new code into a PR, and use the PR build to preview the result. Then, once your CI finishes checking a given PR, you can merge to master confidently, causing now to point your domain alias to the commit you just merged. That's the flow I currently use.

  • reply
  • like

Yeah, that's not too bad, but still... when you merge the PR into your master branch, I would like the tests on the master branch to pass first before the deploy goes out. Just to be extra safe.

  • reply
  • like
private
This channel has been archived